Add missing role to the Katib RBAC#1618
Merged
k8s-ci-robot merged 1 commit intoNov 8, 2020
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
@andreyvelich seems there's some Katib unrelated changes? |
Member
Author
@Jeffwan I only ran It seems that, we haven't generated new tests for the Openshift in this PR: #1567. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
During testing we found that Katib controller ClusterRole should have
taskrunsrole to be able to work with TektonTaskRuns.See this: kubeflow/katib#1380.
I have updated RBAC and image tag to
v1beta1-a96ff59./assign @Jeffwan @johnugeorge @gaocegege
Description of your changes:
Checklist:
cd manifests/testsmake generate-changed-onlymake test